Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing a small bug introduced in #200 #215

Conversation

giovannipizzi
Copy link
Member

When lcount=.true., some content of the
input file that was read was changed, and
the second run (e.g. if 'random' was present)
was giving wrong results.
Not clear because the error was errand, though
(was working on travis but failing on my machine)

When lcount=.true., some content of the
input file that was read was changed, and
the second run (e.g. if 'random' was present)
was giving wrong results.
Not clear because the error was errand, though
(was working on travis but failing on my machine)
@giovannipizzi giovannipizzi added this to the v3.0 milestone Nov 27, 2018
@codecov
Copy link

codecov bot commented Nov 27, 2018

Codecov Report

Merging #215 into develop will not change coverage.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #215   +/-   ##
========================================
  Coverage    61.28%   61.28%           
========================================
  Files           29       29           
  Lines        17098    17098           
========================================
  Hits         10479    10479           
  Misses        6619     6619
Impacted Files Coverage Δ
src/parameters.F90 81.04% <33.33%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16a82bb...d326b8f. Read the comment docs.

Copy link
Collaborator

@VVitale VVitale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work for me, not sure I understand the nature of the bug tbh

@giovannipizzi
Copy link
Member Author

The input file is stored in a list of strings (and slightly modified to remove comments, fix capitalisation etc.)
While before the param_get_projections was called only once, so it wasn't a problem if it was modifying the list of strings, now it's called twice (once to count and once to get them) so it shouldn't change the input array.

@giovannipizzi giovannipizzi merged commit 9d7450f into wannier-developers:develop Nov 28, 2018
@giovannipizzi giovannipizzi deleted the fix_small_bug_lcount_projections branch November 28, 2018 12:33
manxkim pushed a commit to manxkim/wannier90 that referenced this pull request Jan 10, 2021
…l_bug_lcount_projections

Fixing a small bug introduced in wannier-developers#200
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants