-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move SCDM flags to pw2wannier90 #238
Move SCDM flags to pw2wannier90 #238
Conversation
…e of the SCDM flags to pw2wannier90
Codecov Report
@@ Coverage Diff @@
## develop #238 +/- ##
===========================================
+ Coverage 62.01% 62.04% +0.02%
===========================================
Files 29 29
Lines 17161 17132 -29
===========================================
- Hits 10643 10630 -13
+ Misses 6518 6502 -16
Continue to review full report at Codecov.
|
@giovannipizzi has made the following suggestion to make the code fully back-compatible and also in a certain sense forward-compatible with the Mustafa implementation (selection of fewer projections):
or something similar. In this way we pass the info about the number of projections to the SCDM in back compatible way. This block is only written if a specific new flag is |
After discussion, we'll call the flag in Wannier90 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All very good, thanks! I'm approving and merging this even if also the files.tex
should also be updated (nnkp file). I will open an issue for this.
In this way we can already test this new functionality (I will test on QE 6.3). If there are bugs we'll make a new PR.
…w2wannier90 Move SCDM flags to pw2wannier90
This fixes #237.
Moving the four SCDM flags from parameters.F90 to pw2wannier.F90 (now in pwscf/POST-v6.3-with-SCDM folder).
No scdm_info block is written into .nnkp files for back-compatibility.
New behaviour:
Where
num_wann
is the number of projections to use in the SCDM. I have code this in such a way that doesn't break back compatibility.I have also modified kmesh.F90 such as no scdm_info block is written into .nnkp files; overlap.F90 in order to read the new header in the .amn files and set the number of projections accordingly.
I have also made changes to the input files of example27 and modified the tutorial. I have removed the description of the scdm keywords from the user guide but I have left the section describing the SCDM method.