Bugfix in pw2wannier90 when reading projections v6.4 and v6.3 #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #255 +/- ##
========================================
Coverage 62.04% 62.04%
========================================
Files 29 29
Lines 17132 17132
========================================
Hits 10630 10630
Misses 6502 6502Continue to review full report at Codecov.
|
giovannipizzi
approved these changes
Mar 1, 2019
manxkim
pushed a commit
to manxkim/wannier90
that referenced
this pull request
Jan 10, 2021
Bugfix in pw2wannier90 when reading projections v6.4 and v6.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is @giovannipizzi fix to the bug in pw2wannier90 recently introduced (v 3.0.0) when reading data from projection block in .nnkp. I have also changed the pw2wannier90.f90 file in pwscf/v6.3 for compatibility