Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tests for BoltzWann (at least for the electrical conductivity) #282

Merged

Conversation

giovannipizzi
Copy link
Member

I'm adding a simple test to begin with since I got a bug report that I cannot reproduce - by running this also in the test farm, as soon as it's merged, I can check if the problem surfaces on some compiler only

@giovannipizzi giovannipizzi requested a review from jryates July 24, 2019 21:14
@codecov
Copy link

codecov bot commented Jul 24, 2019

Codecov Report

Merging #282 into develop will increase coverage by 1.78%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #282      +/-   ##
==========================================
+ Coverage    63.32%   65.1%   +1.78%     
==========================================
  Files           29      29              
  Lines        17984   17767     -217     
==========================================
+ Hits         11388   11567     +179     
+ Misses        6596    6200     -396
Impacted Files Coverage Δ
src/postw90/geninterp.F90 69.23% <0%> (-5.77%) ⬇️
src/postw90/postw90_common.F90 62.87% <0%> (-5.76%) ⬇️
src/io.F90 67.53% <0%> (-2.82%) ⬇️
src/wannier_prog.F90 80.99% <0%> (-0.98%) ⬇️
src/parameters.F90 81.22% <0%> (-0.76%) ⬇️
src/postw90/kslice.F90 68.4% <0%> (-0.49%) ⬇️
test-suite/library-mode-test/test_library.F90 64.7% <0%> (-0.35%) ⬇️
src/postw90/postw90.F90 84.33% <0%> (-0.19%) ⬇️
src/postw90/kpath.F90 63.53% <0%> (-0.16%) ⬇️
src/postw90/dos.F90 79.16% <0%> (+2.38%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18666f0...811e610. Read the comment docs.

@giovannipizzi giovannipizzi merged commit 894bb26 into wannier-developers:develop Jul 25, 2019
@giovannipizzi giovannipizzi deleted the boltzwann_tests branch July 25, 2019 14:09
manxkim pushed a commit to manxkim/wannier90 that referenced this pull request Jan 10, 2021
…n_tests

Adding tests for BoltzWann (at least for the electrical conductivity)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants