Fix an unused variable that was creating a SEGFAULT #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported by Nicolas Tancogne-Dejean, the bnddataunit(n) = io_file_unit() line was creating a SEGFAULT because the array was not allocated. But anyway, bnddataunit is not really used in the code.
Codecov Report
@@ Coverage Diff @@
## develop #290 +/- ##
==========================================
- Coverage 65.65% 65.6% -0.05%
==========================================
Files 29 29
Lines 17984 17938 -46
==========================================
- Hits 11807 11768 -39
+ Misses 6177 6170 -7
Continue to review full report at Codecov.
|
jryates
approved these changes
Sep 22, 2019
manxkim
pushed a commit
to manxkim/wannier90
that referenced
this pull request
Jan 10, 2021
…ed_bnddataunit Fix an unused variable that was creating a SEGFAULT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported by Nicolas Tancogne-Dejean,
the bnddataunit(n) = io_file_unit() line
was creating a SEGFAULT because the array
was not allocated. But anyway, bnddataunit
is not really used in the code.