-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the bug in the disentanglement step with SAWFs #315
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #315 +/- ##
===========================================
+ Coverage 65.78% 66.39% +0.60%
===========================================
Files 29 29
Lines 17957 17979 +22
===========================================
+ Hits 11813 11937 +124
+ Misses 6144 6042 -102
Continue to review full report at Codecov.
|
There is an error in parallel which causes the test suite to fail. symmetrize_eps is not broadcast off the root node - hence if a none default value is set in the param file different nodes will apply the symmetry constraints to a different tolerance which propagates to give a different overall spread. The fix is to add the following around line 6316 of parameters.f90 In addition the testsuite will fail on OSX because of the line is jobconfig |
Fix a bug in the disentanglement step with SAWFs
The bug was introduced in the following commit 5539b3c
This should now fix it and also works for parallel execution.
Fixes #314