Fix/segfault hamiltonian get hr #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikibonacci
force-pushed
the
fix/segfault-hamiltonian_get_hr
branch
from
3ac85d6
to
ea98aa2
Compare
giovannipizzi
previously requested changes
Feb 16, 2024
JeromeCCP9
approved these changes
Feb 16, 2024
i.e., after the variable declaration. This is needed to avoid allocation on stack if the intel compiler is used, causing segmentation fault for large systems. see issue wannier-developers#439.
…used in the hamiltonian.F90 file. Basically the eigval_opt, utmp variable are allocated only if have_disentangle is true.
in hamiltonian.F90
…sym.F90), the following variables: umatnew, ZU, deltaU, carr. This is in direction of issue wannier-developers#439.
- eigval2, eigval_opt, utmp in hamiltonian_get_hr - umatnew, ZU, deltaU, carr in sitesym_dis_extract_symmetry also, I moved the eigval2 allocation after the *if (ham_logical%have_ham_k) go to 100* line, because if we go to 100, we do not need the eigval2 variale
JeromeCCP9
force-pushed
the
fix/segfault-hamiltonian_get_hr
branch
from
55dc398
to
210b2cd
Compare
JeromeCCP9
approved these changes
Feb 16, 2024
JeromeCCP9
dismissed
giovannipizzi’s stale review
necessary deallocations have been made
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #439.