Skip to content

Commit

Permalink
Remove standalone clang from PATH
Browse files Browse the repository at this point in the history
Use the clang in Visual Studio. Recommended in
actions/runner-images#10001 (comment).
  • Loading branch information
wantehchang committed Jun 11, 2024
1 parent 9d24f8a commit 3a81344
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions .github/workflows/ci-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,10 @@ jobs:
- name: Build aom
if: steps.setup.outputs.ext-cache-hit != 'true'
working-directory: ./ext
run: ./aom.cmd
run: |
# Remove standalone clang from PATH.
$env:PATH = ($env:PATH -split ';' | Where-Object { $_ -ne 'C:\Program Files\LLVM\bin' }) -join ';'
./aom.cmd
# Visual Studio 2022 has an issue starting at 17.8.0 which might cause
# AVX-512 instructions to be emitted in non-AVX-512 code. See
# https://github.com/AOMediaCodec/libavif/issues/2033#issuecomment-1960062751.
Expand All @@ -58,7 +61,10 @@ jobs:
- name: Build libyuv
if: steps.setup.outputs.ext-cache-hit != 'true'
working-directory: ./ext
run: ./libyuv.cmd
run: |
# Remove standalone clang from PATH.
$env:PATH = ($env:PATH -split ';' | Where-Object { $_ -ne 'C:\Program Files\LLVM\bin' }) -join ';'
./libyuv.cmd
# Use clang-cl to build libyuv. The assembly code in libyuv is written in the
# GCC inline assembly format. Visual C++ doesn't support GCC inline assembly.
env:
Expand Down

0 comments on commit 3a81344

Please sign in to comment.