update wasmtime #35
Merged
update wasmtime #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to latest stable release of Rust, this is required to build wasmtime's latest release. Signed-off-by: Flavio Castelli <fcastelli@suse.com>
The lint `const_err` has been removed: converted into hard error, see issue #71800 <rust-lang/rust#71800> for more information Signed-off-by: Flavio Castelli <fcastelli@suse.com>
Update wasmtime-provider to consume latest version of wasmtime Signed-off-by: Flavio Castelli <fcastelli@suse.com>
This was referenced Jan 25, 2023
pkedy
reviewed
Feb 13, 2023
| @@ -44,7 +44,6 @@ | |||
| clippy::equatable_if_let, | |||
| bad_style, | |||
| clashing_extern_declarations, | |||
| const_err, | |||
There was a problem hiding this comment.
@flavio @jsoverson Does removing this require the wapc-codec, wapc-guest, wapc-pool, wasm3-provider, and wapc crates to be version bumped in addition to the wasmtime-provider?
There was a problem hiding this comment.
No, this is not required. Clippy focuses only on the warnings produced by the user code, not by its dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This time the update to latest version of wasmtime required some small changes:
Once this is merged, a new version of the wasmtime provider must be tagged and released.
Note: I did not bump the version of the wasmtime-provider. I can do that if you want, it would just be a patch bump