Correcting the handling of services that have inherited properties #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wardbell
added a commit
that referenced
this pull request
May 6, 2015
Correcting the handling of services that have inherited properties
|
Incorporated in release 0.1.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Object.keys returns only an object's own properties. I ran into an issue where a service was using inheritance internally and the mockService function would not overwrite the inherited properties with _default. Explicitly specifying the inherited property worked but _default did not.
Using the 'for (var key in object)' syntax traverses the prototype chain and allows mockService to overwrite inherited properties not explicitly called out in the config with _default.