Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): use GHCR instead of ECR #172

Merged
merged 1 commit into from
Apr 15, 2024
Merged

feat(ci): use GHCR instead of ECR #172

merged 1 commit into from
Apr 15, 2024

Conversation

jlehtimaki
Copy link
Contributor

@jlehtimaki jlehtimaki commented Apr 15, 2024

This PR will change the builded Docker images to be in GHCR instead of ECR.

Summary by CodeRabbit

  • Refactor
    • Improved the workflow for building and pushing Docker images, including steps for logging into the container registry and enhanced metadata handling.

Copy link
Contributor

coderabbitai bot commented Apr 15, 2024

Walkthrough

Walkthrough

The recent updates focus on enhancing the Docker image build and push process within the GitHub Actions workflow. Key improvements include refined descriptions for workflow inputs, optimized job steps, and advanced handling of metadata and image tagging. These changes aim to streamline operations and increase the efficiency of the container registry interactions.

Changes

File Path Change Summary
.github/workflows/build_push.yml Updated workflow inputs' descriptions, restructured job steps, and enhanced metadata handling.

Recent Review Details

Configuration used: .coderabbit.yaml

Commits Files that changed from the base of the PR and between dbc5193 and 24fe72d.
Files selected for processing (1)
  • .github/workflows/build_push.yml (2 hunks)
Additional comments not posted (7)
.github/workflows/build_push.yml (7)

8-8: Updated input descriptions enhance clarity and user interaction.


24-24: Dynamic inclusion of the service name in the job name improves readability and traceability.


29-29: Permissions settings are correctly configured for pushing images.


32-37: Login step to the container registry is correctly configured using standard GitHub Actions.


38-46: Metadata extraction step is correctly configured using docker/metadata-action.


47-53: Build and push step for Docker images is correctly configured and aligns with the PR's objectives.


55-57: Build arguments are correctly configured, enhancing traceability and version control.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@Pitasi Pitasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jlehtimaki jlehtimaki merged commit f5edd5d into main Apr 15, 2024
5 checks passed
@jlehtimaki jlehtimaki deleted the ecr-to-ghcr branch April 15, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants