Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix goreleaser after CosmWasm #191

Merged
merged 2 commits into from
Apr 17, 2024
Merged

build: fix goreleaser after CosmWasm #191

merged 2 commits into from
Apr 17, 2024

Conversation

Pitasi
Copy link
Contributor

@Pitasi Pitasi commented Apr 17, 2024

Since we're now shipping CosmWasm (that requires CGO), cross-compilation is no longer trivial.

The current solution is to build three binaries:

  • Linux amd64: built in an Alpine Linux container using musl, statically compiled
  • Linux arm64 and Darwin arm64: build using goreleaser-cross in a Debian image using musl

I also added a utility target to Makefile for running the two steps above and upload the artifacts as a GitHub release.

Summary by CodeRabbit

  • New Features

    • Introduced cross-compiling and release targets for ARM64 and Linux AMD64 platforms in the build process.
    • Enhanced release verification for GitHub releases.
  • Chores

    • Updated build configurations to support multiple platforms and architectures.
    • Improved build automation and environment setup for releases.
  • Documentation

    • Updated .gitignore to exclude specific build artifacts.

Copy link
Contributor

coderabbitai bot commented Apr 17, 2024

Walkthrough

Walkthrough

The updates streamline the build and release processes for the "wardend" project, enabling efficient multi-platform targeting. These enhancements encompass improved build configurations for Linux AMD64, refined cross-compiling capabilities, and automated release procedures with enhanced verification and tagging mechanisms.

Changes

File Summary
.gitignore Added dist-linux-amd64 to the ignore list.
.goreleaser-amd64.yaml,
.goreleaser.yaml
Introduce new build configurations for Linux AMD64, adjust setups for various platforms, incorporate pre-build hooks, and disable changelog.
Makefile Augmented with new cross-compiling targets and improved automation for releasing wardend.

Recent Review Details

Configuration used: .coderabbit.yaml

Commits Files that changed from the base of the PR and between 7ea66ae and cad5f3d.
Files selected for processing (4)
  • .gitignore (1 hunks)
  • .goreleaser-amd64.yaml (1 hunks)
  • .goreleaser.yaml (2 hunks)
  • Makefile (2 hunks)
Files skipped from review as they are similar to previous changes (4)
  • .gitignore
  • .goreleaser-amd64.yaml
  • .goreleaser.yaml
  • Makefile

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Pitasi Pitasi force-pushed the fix-goreleaser-cosmwasm branch from 5bfaef8 to cad5f3d Compare April 17, 2024 13:25
@Pitasi Pitasi merged commit 338a810 into main Apr 17, 2024
4 checks passed
@Pitasi Pitasi deleted the fix-goreleaser-cosmwasm branch April 17, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant