Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(shield): grouped expressions not being handled at all #225

Merged
merged 5 commits into from
Apr 25, 2024
Merged

fix(shield): grouped expressions not being handled at all #225

merged 5 commits into from
Apr 25, 2024

Conversation

Pitasi
Copy link
Contributor

@Pitasi Pitasi commented Apr 25, 2024

We were completely ignoring grouped expressions (e.g. expressions wrapped between parentheses such as (true || false)).

This PR adds proper support and tests for this cases.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 25, 2024 •
edited
Loading

Warning

Rate Limit Exceeded

@Pitasi has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 38 minutes and 27 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between 66a0256 and 71f3d7f.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the test label Apr 25, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@Pitasi Pitasi force-pushed the shield-fix-infix-expressions branch 2 times, most recently from feb9511 to 232ea1a Compare April 25, 2024 14:05
Pitasi added 5 commits April 25, 2024 16:10
@Pitasi
fix(shield): handle InfixExpression in ast.Stringify
c6ef4ac 
An entire type of expression was missing in this Stringify method.

I also added a check in case `exp` is nil, so that it's a lot more
evident during debugging if something is missing (e.g. if a field from
an expression is `nil`).
@Pitasi
fix(shield): Stringify function name correctly
d36d735 
We were serializing a struct (n.CallExpression.Function) like it was
just the name of the string, but it wasn't.
@Pitasi
feat(shield): add missing handler for grouped expressions
08fe9ac 
This was a big missing piece for the shield parser, it was not handling
grouped expressions (i.e. expressions wrapped between (...)) at all.
@Pitasi
test(shield): increase Parser test coverage
1203e84
@Pitasi
chore(changelog): fix shield grouped expression
71f3d7f
@Pitasi Pitasi force-pushed the shield-fix-infix-expressions branch from 2af7f10 to 71f3d7f Compare April 25, 2024 14:10
@Pitasi Pitasi enabled auto-merge (rebase) April 25, 2024 14:11
@Pitasi Pitasi disabled auto-merge April 25, 2024 14:14
@Pitasi Pitasi merged commit 8889038 into main Apr 25, 2024
5 checks passed
@Pitasi Pitasi deleted the shield-fix-infix-expressions branch April 25, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mn13 mn13 mn13 approved these changes

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pitasi @mn13