Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ tweak: add logo when calling flags #24

Merged
merged 2 commits into from
Oct 19, 2024

Conversation

spc-28
Copy link
Contributor

@spc-28 spc-28 commented Oct 17, 2024

This pull request adds the logo component to the cli.js such that the logo is displayed, when the flags are called.
Fixes: #22

@spc-28
Copy link
Contributor Author

spc-28 commented Oct 17, 2024

@warengonzaga let me know if anything more is required.

@warengonzaga
Copy link
Owner

All right, this is accepted. I think we need to fix the duplicate description when calling the help. I think we need to update the component logo with props to hide additional information and keep the logo.

@warengonzaga warengonzaga added hacktoberfest-accepted Hacktoberfest (PR) tweak Enhancements (Issue/PR) labels Oct 19, 2024
@warengonzaga warengonzaga changed the title Feat/adding logo to flags ✨ tweak: add logo when calling flags Oct 19, 2024
Copy link
Owner

@warengonzaga warengonzaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM merging to dev.

@warengonzaga warengonzaga merged commit c3fc47a into warengonzaga:dev Oct 19, 2024
@warengonzaga warengonzaga linked an issue Oct 19, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Hacktoberfest (PR) tweak Enhancements (Issue/PR)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

keep the logo at the top of the CLI
2 participants