Apply suggestions from code review

Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
warisa-r · Jun 18, 2024 · b39a753 · b39a753
1 parent 5cdbbc0
commit b39a753
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/src/time_integration/methods_2N.jl b/src/time_integration/methods_2N.jl
@@ -104,8 +104,8 @@ function Base.getproperty(integrator::SimpleIntegrator2N, field::Symbol)
     return getfield(integrator, field)
 end
 
-function init(ode::ODEProblem, alg::T;
-              dt, callback = nothing, kwargs...) where {T <: SimpleAlgorithm2N}
+function init(ode::ODEProblem, alg::SimpleAlgorithm2N;
+              dt, callback = nothing, kwargs...)
     u = copy(ode.u0)
     du = similar(u)
     u_tmp = similar(u)
@@ -132,8 +132,8 @@ function init(ode::ODEProblem, alg::T;
 end
 
 # Fakes `solve`: https://diffeq.sciml.ai/v6.8/basics/overview/#Solving-the-Problems-1
-function solve(ode::ODEProblem, alg::T;
-               dt, callback = nothing, kwargs...) where {T <: SimpleAlgorithm2N}
+function solve(ode::ODEProblem, alg:: SimpleAlgorithm2N;
+               dt, callback = nothing, kwargs...)
     integrator = init(ode, alg, dt = dt, callback = callback; kwargs...)
 
     # Start actual solve

diff --git a/src/time_integration/methods_3Sstar.jl b/src/time_integration/methods_3Sstar.jl
@@ -171,8 +171,8 @@ function Base.getproperty(integrator::SimpleIntegrator3Sstar, field::Symbol)
     return getfield(integrator, field)
 end
 
-function init(ode::ODEProblem, alg::T;
-              dt, callback = nothing, kwargs...) where {T <: SimpleAlgorithm3Sstar}
+function init(ode::ODEProblem, alg:: SimpleAlgorithm3Sstar;
+              dt, callback = nothing, kwargs...)
     u = copy(ode.u0)
     du = similar(u)
     u_tmp1 = similar(u)
@@ -202,8 +202,8 @@ function init(ode::ODEProblem, alg::T;
 end
 
 # Fakes `solve`: https://diffeq.sciml.ai/v6.8/basics/overview/#Solving-the-Problems-1
-function solve(ode::ODEProblem, alg::T;
-               dt, callback = nothing, kwargs...) where {T <: SimpleAlgorithm3Sstar}
+function solve(ode::ODEProblem, alg:: SimpleAlgorithm3Sstar;
+               dt, callback = nothing, kwargs...)
     integrator = init(ode, alg, dt = dt, callback = callback; kwargs...)
 
     # Start actual solve