Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #56 and adds support for Dynamic Volume Provisioning feature.
It implements 2 methods for
Controller
service -CreateVolume
andDeleteVolume
.As
CreateVolume
don't provide an ability to specify an image, which will be passed tovolumeHandle
field inPersistentVolume
object, a customcsi.storage.k8s.io/image
annotation forPersistentVolumeClaim
is used to store it:Also,
CreateVolumeRequest
is lacking information about annotations set onPersistentVolumeClaim
(see kubernetes-csi/external-provisioner#86), so a custom watcher is implemented, which watches and indexesPersistentVolumeClaim
and is used to get this annotation value.PR also includes Helm chart refactoring, so it complies with Recommended mechanism for deploying csi drivers.