disallow completely disabling authentication for a protocol

warp-tech · Jul 10, 2023 · b1995be · b1995be
1 parent 8173f65
commit b1995be
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/warpgate-common/src/auth/policy.rs b/warpgate-common/src/auth/policy.rs
@@ -57,7 +57,9 @@ impl CredentialPolicy for AllCredentialsPolicy {
         let valid_credential_types: HashSet<CredentialKind> =
             valid_credentials.iter().map(|x| x.kind()).collect();
 
-        if valid_credential_types.is_superset(&self.required_credential_types) {
+        if !valid_credential_types.is_empty()
+            && valid_credential_types.is_superset(&self.required_credential_types)
+        {
             CredentialPolicyResponse::Ok
         } else {
             CredentialPolicyResponse::Need(