-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for trusting X-Forwarded-For header to get client IP #921
Conversation
falls back to remote ip if header unavailable
Thanks! Would you consider adding support for |
Sure thing, what do you think the |
It's used to construct external URLs for SSO and SSH 2FA. The case doesn't matter because header name matching in both |
Ah perfect, I should be able to work on that just fine then. I'll update my bits to use the static header string declarations! |
This works quite nicely now, have tested running behind traefik with multiple hostnames, ports and http/https and the SSO redirect works perfectly. Tested with SSH SSO as well and appears to be working |
I've reordered things slightly for readability ✌️ Thanks! |
This fixes #882
falls back to remote ip if header unavailable
Added
trust_x_forwarded_headers
option in warpgate.yaml config