Enhance ticket creation api and UI to support ticket expiry #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket expiry was already supported on core but no way to defined it, neither from UI neither from API Changed API to accept new optional field `expiry` and update UI form to be able to set it from UI closes warp-tech#924
|
Test failed regarding missing SONAR_TOKEN, I don't think is related at all with code |
|
Maybe change label
by
What do you think? |
|
Thank you! I've cleaned it up a bit and updated the SDK to make it the request parameter work - added some details about this to the README |
|
@all-contributors add @kakawait for code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket expiry was already supported on core but no way to defined it, neither from UI neither from API
Changed API to accept new optional field
expiryand update UI form to be able to set it from UIcloses #924
UI changes
I've not yet implemented ticket number usage because I'm totally new on Rust and Svelte (even TS). I'd like to validate that addition firstly before starting more development.
If ok for you, I could continue PR to add this part