Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance ticket creation api and UI to support ticket number of usage #959

Merged
merged 5 commits into from
Mar 4, 2024

Conversation

kakawait
Copy link
Contributor

@kakawait kakawait commented Mar 3, 2024

Ticket uses left was already supported on core but no way to defined it, neither from UI neither from API

Changed API to accept new optional field and update UI form to be able to set it from UI

related #924


UI changes

Screenshot 2024-03-04 at 00 15 11 Screenshot 2024-03-04 at 00 13 58

Ticket uses left was already supported on core but no way to defined it,
neither from UI neither from API

Changed API to accept new optional field  and update UI form to
be able to set it from UI

related warp-tech#924
@kakawait
Copy link
Contributor Author

kakawait commented Mar 3, 2024

numberOfUsage can be reworded but didn't find better. But also not totally satisfied

@Eugeny
Copy link
Member

Eugeny commented Mar 3, 2024

numberOfUses would be correct

@kakawait
Copy link
Contributor Author

kakawait commented Mar 4, 2024

numberOfUses would be correct

Fixed

In addition, I've added min=1 for input type=number because no sense to be able to add numberOfUses lower than 1

@Eugeny Eugeny merged commit f3dc1ad into warp-tech:main Mar 4, 2024
6 of 7 checks passed
@Eugeny
Copy link
Member

Eugeny commented Mar 4, 2024

LGTM, thank you!

@marco-adeti
Copy link

marco-adeti commented Sep 6, 2024

On 0.10.2, the numberOfUses is decreased by 3 (50->47->44...)
If less than 3, can't use ticket. it directly "Used up"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants