testexec: getting exit codes correctly. #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Which remains a bit of a bear, apparently. Especially if you want to talk accurrately about signals.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExecFn_ExecandScriptFn_ExecBash(the defaults) now return exit codes correctly.I've gone perhaps a bit overboard in also making sure that death-by-signal is reported, too. Maybe this won't stick around (especially because it requires importing the syscall packaage, which might otherwise be avoidable on recentish versions of golang), because I don't know if it's critically relevant and likely to actually get exercised much in this domain... but I've written it, so let's see if it sticks.