WIP: Add initial CmdWaitRule #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add initial CmdWaitRule to check becuase ``cmd.run`` should be used together with ``onchanges`` instead of ``cmd.wait``. This commit also deletes `pyyaml` as a dependency, because we now use the yaml libs of salt itself. Signed-off-by: Roald Nefs <info@roaldnefs.com>
This was referenced Oct 11, 2019
Signed-off-by: Roald Nefs <info@roaldnefs.com>
Signed-off-by: Roald Nefs <info@roaldnefs.com>
This was referenced Oct 11, 2019
|
Closing this PR because the way YAML is handled needs to be changed. Removing the Jinja results in duplicate keys (e.g. same State ID in if and else block). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add initial CmdWaitRule to check becuase
cmd.runshould be used together withonchangesinstead ofcmd.wait.According to the salt.states.cmd.wait documentation:
This commit also deletes
pyyamlas a dependency, because we now use the yaml libs of salt itself.