Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update parquet-go to v0.23.0 to fix Go 1.23 link error #105

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Update parquet-go to v0.23.0 to fix Go 1.23 link error #105

merged 1 commit into from
Aug 22, 2024

Conversation

tuhtah
Copy link
Contributor

@tuhtah tuhtah commented Aug 21, 2024

Fixes #104

@gregfurman
Copy link
Collaborator

gregfurman commented Aug 22, 2024 •
edited
Loading

Hey! Thanks for this. Just want to confirm the integration tests for parquet_encode and parquet_decode pass on your local?

edit: nvm there are only unit tests. I'm testing this in a Docker image locally just to validate all works.

gregfurman
gregfurman approved these changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@gregfurman gregfurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recreated issue locally on golang:1.23.0-bullseye and validated that the updated dependencies work with your changes. Thanks again for raising this!

LGTM 💯

@gregfurman gregfurman merged commit a365007 into warpstreamlabs:main Aug 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregfurman gregfurman gregfurman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Linker error when building with Go 1.23
2 participants
@tuhtah @gregfurman