change v4 to v1 #27
Merged
change v4 to v1 #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregfurman
reviewed
Jun 6, 2024
CHANGELOG.old.md
Outdated
Comment on lines
737
to
738
| - Go API: Module name has changed to `github.com/warpstreamlabs/bento`. | ||
| - Go API: All packages within the `lib` directory have been removed in favour of the newer [APIs within `public`](https://pkg.go.dev/github.com/warpstreamlabs/bento/public). |
There was a problem hiding this comment.
nit: Not sure if editing the CHANGELOG..old.md is necessary. Should the entire changelog not rather just immutably remain as it was from when the fork was created?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bento breaks with Benthos v4 version and starts at 1, so we need to remove the v4 suffix.
https://go.dev/ref/mod