-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deploy-docsite workflow, Add build docsite to test workflow #47
Conversation
Changes:
I have made this repo with a change to the favicon to test - link to site. |
on: | ||
workflow_dispatch: | ||
push: | ||
branches: [main] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this also happen on tag creation/release events?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that you could do either: on pushes to main OR a release event, I think if you did both you would be rebuilding the same site on a release event.
If we decide to only re-build the docsite on release then we can still trigger the build manually in the github UI for small fixes, i.e. favicon changes.
@richardartoul what do you reckon?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah sure I see what you're saying. Perhaps just on main is fine since calling go install
with latest
will return HEAD of main in any case.
Signed-off-by: Jem Davies <jemsot@gmail.com>
Signed-off-by: Jem Davies <jemsot@gmail.com>
Signed-off-by: Jem Davies <jemsot@gmail.com>
Signed-off-by: Jem Davies <jemsot@gmail.com>
462f99a
to
41f1d88
Compare
YOU WILL NEED TO CHANGE A SETTING
In the github repo UI: