upstream changes #56
Merged
upstream changes #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jem-davies
commented
Jun 23, 2024
jem-davies
commented
Jun 23, 2024
jem-davies
commented
Jun 23, 2024
* Add blobl example tests back in The example tests used to be performed in a single place, which was the same package responsible for generating the docs. However, that package now exists within the connect repository and so it makes sense to add the tests in here so that we can catch example issues earlier. * Use format directive Signed-off-by: Jem Davies <jemsot@gmail.com>
Signed-off-by: Jem Davies <jemsot@gmail.com>
Signed-off-by: Jem Davies <jemsot@gmail.com>
jem-davies
force-pushed
the
jem-upstream-changes
branch
from
fe01337
to
776e827
Compare
Signed-off-by: Jem Davies <jemsot@gmail.com>
gregfurman
reviewed
Jun 27, 2024
Co-authored-by: Greg Furman <31275503+gregfurman@users.noreply.github.com>
Co-authored-by: Greg Furman <31275503+gregfurman@users.noreply.github.com>
|
LGTM @jem-davies -- feel free to merge when ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gregfurman
Please can you take a look?
I had an issue with some missing func
TemplateData()in ./public/bloblang/view.go - that was added on this commit a couple of weeks ago, I have edited the commit manually to include here. Not sure if this is best way?