Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serverless housekeeping: Local testing guide, small docs fixes, and some handler tests for errors #62

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Serverless housekeeping: Local testing guide, small docs fixes, and some handler tests for errors #62

merged 2 commits into from
Jul 3, 2024

Conversation

gregfurman
Copy link
Collaborator

Some small fixes/improvements:

@gregfurman gregfurman force-pushed the serverless-house-keeping branch 2 times, most recently from 9e7d887 to d0306c4 Compare June 29, 2024 15:53
jem-davies
jem-davies requested changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@jem-davies jem-davies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me - just a few nitpicky things - feel free to ignore them if you think it better how it is 👍

internal/serverless/handler_test.go Outdated Show resolved Hide resolved
@gregfurman gregfurman merged commit e8d1e92 into warpstreamlabs:main Jul 3, 2024
3 checks passed
@gregfurman gregfurman deleted the serverless-house-keeping branch July 3, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jem-davies jem-davies jem-davies approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregfurman @jem-davies