Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component: Add input for etcd key or prefix watcher #66

Merged
merged 3 commits into from
Aug 18, 2024

Conversation

gregfurman
Copy link
Collaborator

@gregfurman gregfurman commented Jul 5, 2024

Changes

  • Create new etcd Watch input, that will watch for new PUT or DELETE operations on a specific key or prefix (see Watch API docs).
  • Add integration tests for watching a single key and all keys for changes.
  • Include extensive configuration options for watch stream operations.
  • Updated website with new docs.

TODO

  • Determine version this will be released in -- currently set as 1.x.x
  • Include a better description for the etcd component
  • Improve the leasing capabilities
  • Create an output sink for operating on etcd (i.e PUTs, DELETEs, new lease creation)

@gregfurman gregfurman requested a review from jem-davies July 5, 2024 09:03
@gregfurman gregfurman force-pushed the etcd-component branch 3 times, most recently from 05d0303 to 7b14e67 Compare July 5, 2024 12:08
Copy link
Collaborator

@jem-davies jem-davies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some changes required I think

@gregfurman gregfurman force-pushed the etcd-component branch 2 times, most recently from 94673f6 to f1eed20 Compare July 24, 2024 16:12
@danriedl
Copy link

hey just checking in,
to let you know i created a PR for etcd cache/input in the old benthos-dev/benthos project in april:
redpanda-data/connect#2555

@gregfurman
Copy link
Collaborator Author

Hey @danriedl! Wow that looks awesome. Since you have context on etcd, Go, and delcarative pipelines, would love it if you gave these changes a look? Else, if you want to try combine our solutions I think that'd be awesome.

Happy to chat on Discord or Slack too :)

@gregfurman gregfurman merged commit d61e12d into warpstreamlabs:main Aug 18, 2024
3 checks passed
@gregfurman gregfurman deleted the etcd-component branch August 18, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants