Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove references to depreciated function meta() in docs #97

Merged
merged 3 commits into from
Sep 8, 2024

Conversation

jem-davies
Copy link
Collaborator

No description provided.

Signed-off-by: Jem Davies <jemsot@gmail.com>
…eta() + metadata() functions

Signed-off-by: Jem Davies <jemsot@gmail.com>
Signed-off-by: Jem Davies <jemsot@gmail.com>
@jem-davies jem-davies requested a review from gregfurman August 18, 2024 14:47
Copy link
Collaborator

@gregfurman gregfurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! This deprecation isn't apparent on the docs though: https://warpstreamlabs.github.io/bento/docs/guides/bloblang/functions/#meta

Maybe we should consider fixing the deprecated labelling too?

Also, I found quite a few docs where meta is still referenced (a few of them are ref'd below):

http_server 
sql_raw 
system_window 
aws_dynamodb 
aws_s3 
azure_blob_storage 
cache 
gcp_cloud_storage 
nats 
nats_jetstream 
redis_hash 
snowflake_put 
sql 
sql_insert 
sql_raw 
aws_dynamodb_partiql 
azure_cosmosdb 
cached 
dedupe 
group_by 
group_by_value 
javascript 
log 
metric 
nats_request_reply 
parquet_decode 
redis 
redis_script 
sql 
sql_insert 
sql_raw 
sql_select 

Should we do this all at once or you wanna make a follow-up PR?

@jem-davies
Copy link
Collaborator Author

Think to do a follow up PR because I did originally see them but needed to check because some of them have type casting because the old function only worked with Strings as the metadata value.

@jem-davies jem-davies merged commit ed53b15 into main Sep 8, 2024
3 checks passed
@jem-davies jem-davies deleted the fix-metadata-page branch September 8, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants