Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for diffrent ApplicationHost.Config files #36

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

davidsandstrom
Copy link

No description provided.

@warrenbuckley
Copy link
Owner

Hi @davidsandstrom
This looks good & great work.

Code changes looks fine to me at a quick glance, but I will want to test it - its good that its a config option. Do you think we should try to auto detect pick up the applicationHost config from VS SLN's.

Thoughts?

@davidsandstrom
Copy link
Author

davidsandstrom commented Feb 23, 2018 via email

… .vscode folder. Config file specified in settings overrides local file in .vscode folder
@davidsandstrom
Copy link
Author

Added support for dropping applicationhost.config file in .vscode folder.

@warrenbuckley
Copy link
Owner

@davidsandstrom I will try to get to this over the weekend - my week has been hectic here with the snow in the UK. Us Brits are not prepared for it :-P

@MikesGlitch
Copy link

MikesGlitch commented Apr 26, 2018

I need this in my life

@Spinarooni
Copy link

Any chance we get this merged?

@nickdepinet
Copy link

This has been sitting for almost a year now, can we get this merge?

@AceTheWiz
Copy link

I also have a requirement to allow external network access to IIS Express. To acheive this set the Binding property to accept connections from any IP, not only localhost. See this blog.
Basically instead of this
<binding protocol="http" bindingInformation="*:5258:localhost" />
we use this
<binding protocol="http" bindingInformation="*:5258:*" />

Warren, are you alive. :)

@warrenbuckley
Copy link
Owner

I am sorry all.
This project was created and has been working fine for me and my own usages and as this was a pet project its got a bit neglected around my day job and family life.

Sorry

Setup Dependabot on the repo and I need to check that's all working later today/this week and then I can get through the backlog of PRs & issues reported on this repo.

Copy link
Owner

@warrenbuckley warrenbuckley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code in PR looks fine. I will need to test & verify this.
Just two years too late...... 🙈

@warrenbuckley warrenbuckley changed the base branch from master to develop July 3, 2020 10:00
@davidsandstrom
Copy link
Author

Do i need to do anyting else to get this merged? Its been sitting here for a while now ;-)

@JoeyPriceless
Copy link

Would be nice to have

protocol: options.protocol ? options.protocol : settings.protocolType.http,

//Path to ApplicationHost.Config
config: options.config ? options.config : '';

Check notice

Code scanning / CodeQL

Syntax error

Error: ',' expected.
@lextm
Copy link

lextm commented Mar 23, 2023

While this pull request adds a little bit flexibility, it does not have JetBrains Rider in mind, as there .rider folder is used, not .vscode. So, a more general approach is to allow VS Code users to choose whatever config file they want and let them be responsible for the contents. That's what I choose in the new IIS/IIS Express extension for VS Code.

@warrenbuckley
Copy link
Owner

Hi @lextm thanks for commenting and giving your opinion.
However, it is good to have alternative VSCode extensions in the community and different options, however promoting it on issues and PRs to this repository is slightly distasteful and not in the spirit of open source IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants