Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JSON Schema to use local file #97

Merged
merged 3 commits into from
Jul 9, 2020

Conversation

warrenbuckley
Copy link
Owner

Rather than using the file hosted directly on GitHub it should use the local file - as is confusing why it was not updating when developing

…e local file - as is confusing why it was not updating when developing
@warrenbuckley
Copy link
Owner Author

Need to verify this works when packaged up & distributed

@warrenbuckley
Copy link
Owner Author

Glad I checked, yes this would not work as the file is not included when using the vsce global npm cli tool for publishing VSCode packages.

C:\Code-Personal\IIS-Express-Code>vsce ls
Executing prepublish script 'npm run vscode:prepublish'...

> iis-express@1.1.2 vscode:prepublish C:\Code-Personal\IIS-Express-Code
> npm run compile


> iis-express@1.1.2 compile C:\Code-Personal\IIS-Express-Code
> tsc -p ./

C:\Code-Personal\IIS-Express-Code>vsce ls
Executing prepublish script 'npm run vscode:prepublish'...

> iis-express@1.1.2 vscode:prepublish C:\Code-Personal\IIS-Express-Code
> npm run compile


> iis-express@1.1.2 compile C:\Code-Personal\IIS-Express-Code
> tsc -p ./

.github/dependabot.yml
.github/FUNDING.yml
CHANGELOG.md
images/iis-express-icon.png   
images/iis-express-install.gif
images/iis-express-usage.gif  
images/iis-icon.png
out/extension.js
out/IISExpress.js
out/install.js
out/settings.js
out/verification.js
package.json
README.md
node_modules/iconv-lite/.github/dependabot.yml
node_modules/iconv-lite/Changelog.md
node_modules/iconv-lite/encodings/dbcs-codec.js
node_modules/iconv-lite/encodings/dbcs-data.js
node_modules/iconv-lite/encodings/index.js
node_modules/iconv-lite/encodings/internal.js
node_modules/iconv-lite/encodings/sbcs-codec.js
node_modules/iconv-lite/encodings/sbcs-data-generated.js
node_modules/iconv-lite/encodings/sbcs-data.js
node_modules/iconv-lite/encodings/tables/big5-added.json
node_modules/iconv-lite/encodings/tables/cp936.json
node_modules/iconv-lite/encodings/tables/cp949.json
node_modules/iconv-lite/encodings/tables/cp950.json
node_modules/iconv-lite/encodings/tables/eucjp.json
node_modules/iconv-lite/encodings/tables/gb18030-ranges.json
node_modules/iconv-lite/encodings/tables/gbk-added.json
node_modules/iconv-lite/encodings/tables/shiftjis.json
node_modules/iconv-lite/encodings/utf16.js
node_modules/iconv-lite/encodings/utf32.js
node_modules/iconv-lite/encodings/utf7.js
node_modules/iconv-lite/lib/bom-handling.js
node_modules/iconv-lite/lib/index.js
node_modules/iconv-lite/lib/streams.js
node_modules/iconv-lite/LICENSE
node_modules/iconv-lite/package.json
node_modules/iconv-lite/README.md
node_modules/safer-buffer/dangerous.js
node_modules/safer-buffer/LICENSE
node_modules/safer-buffer/package.json
node_modules/safer-buffer/Porting-Buffer.md
node_modules/safer-buffer/Readme.md
node_modules/safer-buffer/safer.js
node_modules/safer-buffer/tests.js
node_modules/jsonfile/CHANGELOG.md
node_modules/jsonfile/index.js
node_modules/jsonfile/LICENSE
node_modules/jsonfile/package.json
node_modules/jsonfile/README.md
node_modules/jsonfile/utils.js
node_modules/graceful-fs/clone.js
node_modules/graceful-fs/graceful-fs.js
node_modules/graceful-fs/legacy-streams.js
node_modules/graceful-fs/LICENSE
node_modules/graceful-fs/package.json
node_modules/graceful-fs/polyfills.js
node_modules/graceful-fs/README.md
node_modules/universalify/index.js
node_modules/universalify/LICENSE
node_modules/universalify/package.json
node_modules/universalify/README.md
node_modules/uuid/CHANGELOG.md
node_modules/uuid/CONTRIBUTING.md
node_modules/uuid/dist/bin/uuid
node_modules/uuid/dist/bytesToUuid.js
node_modules/uuid/dist/esm-browser/bytesToUuid.js
node_modules/uuid/dist/esm-browser/index.js
node_modules/uuid/dist/esm-browser/md5.js
node_modules/uuid/dist/esm-browser/rng.js
node_modules/uuid/dist/esm-browser/sha1.js
node_modules/uuid/dist/esm-browser/v1.js
node_modules/uuid/dist/esm-browser/v3.js
node_modules/uuid/dist/esm-browser/v35.js
node_modules/uuid/dist/esm-browser/v4.js
node_modules/uuid/dist/esm-browser/v5.js
node_modules/uuid/dist/esm-node/bytesToUuid.js
node_modules/uuid/dist/esm-node/index.js
node_modules/uuid/dist/esm-node/md5.js
node_modules/uuid/dist/esm-node/rng.js
node_modules/uuid/dist/esm-node/sha1.js
node_modules/uuid/dist/esm-node/v1.js
node_modules/uuid/dist/esm-node/v3.js
node_modules/uuid/dist/esm-node/v35.js
node_modules/uuid/dist/esm-node/v4.js
node_modules/uuid/dist/esm-node/v5.js
node_modules/uuid/dist/index.js
node_modules/uuid/dist/md5-browser.js
node_modules/uuid/dist/md5.js
node_modules/uuid/dist/rng-browser.js
node_modules/uuid/dist/rng.js
node_modules/uuid/dist/sha1-browser.js
node_modules/uuid/dist/sha1.js
node_modules/uuid/dist/umd/uuid.min.js
node_modules/uuid/dist/umd/uuidv1.min.js
node_modules/uuid/dist/umd/uuidv3.min.js
node_modules/uuid/dist/umd/uuidv4.min.js
node_modules/uuid/dist/umd/uuidv5.min.js
node_modules/uuid/dist/uuid-bin.js
node_modules/uuid/dist/v1.js
node_modules/uuid/dist/v3.js
node_modules/uuid/dist/v35.js
node_modules/uuid/dist/v4.js
node_modules/uuid/dist/v5.js
node_modules/uuid/LICENSE.md
node_modules/uuid/package.json
node_modules/uuid/README.md
node_modules/uuid/wrapper.mjs

C:\Code-Personal\IIS-Express-Code> 

@warrenbuckley
Copy link
Owner Author

OK needed to update .vscodeignore file to explicitly include the JSON schema file.
Re-running the vsce ls command showed it would be a file that would get packaged up

@warrenbuckley warrenbuckley merged commit 29a7f9a into develop Jul 9, 2020
@warrenbuckley warrenbuckley deleted the bugfix/use-local-schema-file branch July 9, 2020 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant