Add react-svg-piechart #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgajowy
requested changes
Jun 24, 2018
src/topic/components/Participants.js
Outdated
| import Colors from '../../styles/Colors'; | ||
|
|
||
| const Participants = props => { | ||
| const VOTES_NEEDED = 40; |
There was a problem hiding this comment.
as this is a render method, you are re-declaring const meant in each rendering. What do you think to move out the VOTES_NEEDED and Chart Data out of this function?
src/topic/components/Participants.js
Outdated
| import PieChart from 'react-svg-piechart'; | ||
| import Colors from '../../styles/Colors'; | ||
|
|
||
| const Participants = props => { |
There was a problem hiding this comment.
A general rule of thumb is - if you are using any object more than once, destruct it! (you may want to take a look at fb's react's example there
In Participants we have it twice, so we can improve it by declaring:
const Participants = ({likes}) => { ... }
src/topic/components/Participants.js
Outdated
| return (<StyledParticipants> | ||
| <PieChart | ||
| data={chartData} | ||
| // If you need expand on hover (or touch) effect |
There was a problem hiding this comment.
[opinion/minor] I believe that props are more like self-explandatory - thus no additional comments are necessary
Tuhaj
pushed a commit
that referenced
this pull request
Aug 15, 2018
* Add react-svg-piechart * Update after CR
Tuhaj
pushed a commit
that referenced
this pull request
Aug 15, 2018
* chore: update Trainer component and add tests * chore: add TrainersList tests * Disable lint for redux devtools extension * chore: update argument naming to be more meaningful * Add react-svg-piechart (#24) * Add react-svg-piechart * Update after CR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.