Feature/become trainer #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tuhaj
requested changes
Aug 16, 2018
| }); | ||
| }); | ||
|
|
||
| describe('when ApiService return confirmation', () => { |
There was a problem hiding this comment.
'when ApiService returns confirmation'
| export const ActionButton = styled.button` | ||
| width: 201px; | ||
| height: 40px; | ||
| background-color: #e6cf42; |
There was a problem hiding this comment.
no reason to do so. Action button is meant to be a "Primary Action Button" (CTA) and it has one, special color as on designs. Primary / secondary colors should rather be a part of theme which styled components support
src/lib/PrimaryActionButton.js
Outdated
| const PrimaryButton = props => ( | ||
| <ActionButton {...props}> | ||
| {' '} | ||
| <ActionButtonSpanText>{props.children}</ActionButtonSpanText>{' '} |
There was a problem hiding this comment.
this is somehow ugly, maybe new line can help for the space?
There was a problem hiding this comment.
I think it is a leftover, will remove!
| .then(user => { | ||
| if (user) { | ||
| this.props.loginSuccess(user); | ||
| // TODO how to? this.history.push('/'); |
| return ( | ||
| <div> | ||
| {alreadyAttending && ( | ||
| <PrimaryButton onClick={this.leave}> |
There was a problem hiding this comment.
its not reusable anywhere and most likely will not be. We already have a nice reusable component of PrimaryButton. Could you please point out what income would be from making it a component?
Tuhaj
approved these changes
Aug 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/callback?token=...stuff implied login error as token was already used onceopened task for future: