Chore/hooks - eslint & tests #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tuhaj
approved these changes
May 26, 2018
| 'rules': { | ||
| 'indent': [ | ||
| 'error', | ||
| 4 |
There was a problem hiding this comment.
I prefer 4 :) but we can agree on any setting!
|
|
||
| class TopBar extends Component { | ||
| class TopBar extends React.Component { |
There was a problem hiding this comment.
@Tuhaj it does not matter - both effect is the same (i.e. either importing React, {Component} or just React). The only reason why I picked React.Component is that Component is a generic name that any library may export. By using React.Component we strictly say "hey, this will be React.Component!" - as Component is a common name and may be used by other libraries.
| @@ -22,16 +23,20 @@ class TopBar extends Component { | |||
| <Text type="basic" color={ Colors.white } display={ 'inline' }> | |||
| Zaloguj się przez GitHub | |||
| </Text> | |||
| <Button marginLeft='10px' onClick={this.onClick} | |||
| type="primary"> | |||
| <Button marginLeft='10px' onClick={this.onClick} type="primary"> | |||
There was a problem hiding this comment.
To be honest I haven't even noticed, as my changes only re-formatted this part. Will check this within next PR. Good catch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6