Skip to content

Commit

Permalink
Pyluwen: Add "version" to pyproject.toml
Browse files Browse the repository at this point in the history
Maturin made a change to come inline more specifically with
pyproject.toml spec, unfortunately it's not a "backwards compatible"
change and was done with little fanfare or warning, and immediately
caused breakage outside distro's more plodding versions.

Maturin Issue: PyO3/maturin#2390
pyproject.toml spec: https://packaging.python.org/en/latest/specifications/pyproject-toml/#dynamic

change in Maturin committed here:

PyO3/maturin#2391

This commit superceeds the luwen PR here:

tenstorrent#11

as that sets an explicit version, and we don't want that as it adds more
sources of truth on the version (seriously there should be 1, and only
1).

Signed-off-by: John 'Warthog9' Hawley <jhawley@tenstorrent.com>
  • Loading branch information
warthog9 committed Dec 30, 2024
1 parent 59feb86 commit 6f622ea
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions crates/pyluwen/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ build-backend = "maturin"
[project]
name = "pyluwen"
requires-python = ">=3.7"

dynamic = ["version"]

classifiers = [
"Programming Language :: Rust",
"Programming Language :: Python :: Implementation :: CPython",
Expand Down

0 comments on commit 6f622ea

Please sign in to comment.