Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump detekt-formatting from 1.18.1 to 1.19.0 #56

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 30, 2021

⚠️ Dependabot is rebasing this PR ⚠️

Rebasing might not happen immediately, so don't worry if this takes some time.

Note: if you make any changes to this PR yourself, they will take precedence over the rebase.


Bumps detekt-formatting from 1.18.1 to 1.19.0.

Release notes

Sourced from detekt-formatting's releases.

v1.19.0-RC2

v1.19.0-RC1 - 2021-11-18

Notable Changes
  • We now offer an ignoreAnnotated configuration key that you can use on all your rules to suppress findings if inside an annotated block (e.g. @Composable) - #4102 and #4241
  • Report configuration is changing in the Gradle plugin. The reports extension on the detekt extension has been deprecated. See the Migration section below for steps to migrate to the new recommended configuration - #3687
  • The ExplicitCollectionElementAccessMethod rule is now a type-resolution only rule - #4201
  • The InvalidPackageDeclaration rule has been split to create the MissingPackageDeclaration rule - #4149
  • The ForbiddenComment rule now offers a customMessage configuration key - #4126
  • We bumped ktlint and updated the default enabled rules to mirror what ktlint is doing - #4179
  • Added a new LambdaParameterNaming rule, to enfornce a naming convention of paramter inside lambdas - #4147
  • Added a new InjectDispatcher rule, to check if dispatchers are injectable - #4222
  • Added a new ConsoleReport format - #4027
  • Gradle: We added the --auto-correct cmdline option to gradle tasks - #4202
  • Gradle: We removed the afterEvaluate wrapper from the Android and KMM plugin - #4159 and #4271
  • We now test against Java 17 and stopped testing against Java 16 - #4136
  • Remove library specific configurations like Jetpack Compose and Dagger from the default config - #4101
  • Remove detekt-bom module - #4043
  • Use reference in fallback property delegate - #3982
Migration

Configuring reports in the Gradle plugin should be done at the task level instead of at the extension (or global) level. The previous recommendation resulted in the report output for multiple tasks overwriting each other when multiple detekt tasks were executed in the same Gradle run.

Before this release the recommended way to configure reports was using the detekt extension:

detekt {
    reports {
        xml {
            enabled = true
            destination = file("build/reports/detekt/detekt.xml")
        }
    }
}

This meant all detekt tasks would output the report to the same destination. From this detekt release you should enable and disable reports for all tasks using the withType Gradle method:

// Kotlin DSL
tasks.withType<Detekt>().configureEach {
    reports {
        xml.required.set(true)
    }
}
</tr></table> 

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [detekt-formatting](https://github.com/detekt/detekt) from 1.18.1 to 1.19.0.
- [Release notes](https://github.com/detekt/detekt/releases)
- [Commits](https://github.com/detekt/detekt/commits)

---
updated-dependencies:
- dependency-name: io.gitlab.arturbosch.detekt:detekt-formatting
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Nov 30, 2021
@warting warting merged commit d6eb472 into main Dec 2, 2021
@warting warting deleted the dependabot/gradle/io.gitlab.arturbosch.detekt-detekt-formatting-1.19.0 branch December 2, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code production
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant