Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve INP for drawer content opening and closing #642

Merged
merged 26 commits into from
Jun 12, 2024
Merged

fix: improve INP for drawer content opening and closing #642

merged 26 commits into from
Jun 12, 2024

Conversation

artmsilva
Copy link
Contributor

@artmsilva artmsilva commented Jun 6, 2024 •
edited
Loading

What I did

We can use useTransition API and data attributes to style in order to improve INP.

See the alpha test build on spectrum https://github.com/WashPost/spectrum/pull/5141. See that PR for testing steps

@vercel Vercel
Copy link

vercel bot commented Jun 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
wpds-ui-kit ✅ Ready (Inspect) Visit Preview Jun 11, 2024 5:16pm
wpds-ui-kit-storybook ✅ Ready (Inspect) Visit Preview Jun 11, 2024 5:16pm

@artmsilva artmsilva marked this pull request as ready for review June 6, 2024 10:41
@artmsilva artmsilva requested a review from a team as a code owner June 6, 2024 10:41
@artmsilva artmsilva merged commit 8f6de93 into main Jun 12, 2024
10 of 11 checks passed
@artmsilva artmsilva deleted the drawer-transition branch June 12, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wp-aberg wp-aberg wp-aberg left review comments

@val-l-hosler val-l-hosler val-l-hosler approved these changes

@atomictangerine atomictangerine atomictangerine approved these changes

@ebgranger ebgranger ebgranger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@artmsilva @ebgranger @atomictangerine @val-l-hosler @wp-aberg