Use correct command for docker compose
#23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`docker-compose` (V1) has been deprecated since July 2023, and Compose V2 is its replacement. Since V2 was announced, it was always available as `docker compose` rather than the single command `docker-compose`. Modern installations of Docker no longer even ship with `docker-compose` itself.
|
Thank you, and yeah I would rather keep docker compose. If someone for some reason uses a older version that's on them. |
|
Sorry, mistook the close with comment button for merge with comment 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker-compose(V1) has been deprecated since July 2023, and Compose V2 is its replacement. Since V2 was announced, it was always available asdocker composerather than the single commanddocker-compose. Modern installations of Docker no longer even ship withdocker-composeitself.📑 Context
See Docker's page titled "Migrate to Compose V2" which explains that the single command
docker-composewith a hyphen was part of V1 and is now deprecated. Users should instead usedocker compose, and the page mentions that this process started a while back:I can confirm that I was unable to follow the
READMEto start 13ft, sincedocker-composeis not available on my machine:$ docker-compose zsh: command not found: docker-compose✅ Checks
docker compose upjust as expected.ℹ Additional Information
A possible improvement here would be to also mention
docker-composeas a fallback if anyone is running a very old version of Docker, but then you'd have to decide also how long to keep this mention in theREADMEfor… overall this doesn't really seem worth it.docker-composehas been deprecated for a while and is well on its way out.The new line added after the list is to make sure it doesn't bring the one right after next to it.