Address rustsec dalek advisory #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
thomastaylor312
requested review from
autodidaddict and
brooksmtownsend
as code owners
|
For good measure I also did a manual test of a key that is generated by the previous version of nkeys (before this) and it also works ok (both parsing, and signing and validating messages) |
Signed-off-by: Taylor Thomas <taylor@cosmonic.com>
thomastaylor312
force-pushed
the
jszwedko/update-ed25519_dalek
branch
from
8a8d1eb to
27c8cdc
Compare
autodidaddict
approved these changes
Aug 15, 2023
|
Thanks for taking this across the line @thomastaylor312 ! |
|
Thank you for doing all the initial leg work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of and supersedes #22 (thanks @jszwedko!). It also bumps the crate version so we can release a new version
Closes #20