chore: Remove JWK feature #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joonas
requested review from
autodidaddict,
brooksmtownsend and
thomastaylor312
as code owners
|
As an aside, I would love to cut a new release ( |
protochron
approved these changes
Jul 18, 2024
brooksmtownsend
approved these changes
Jul 18, 2024
|
would love to get this in as part of #45 🙂 |
Signed-off-by: Joonas Bergius <joonas@cosmonic.com>
brooksmtownsend
force-pushed
the
chore/remove-jwk-feat
branch
from
81783ff to
f254961
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
In hindsight, the thing that needed to be implemented to make it possible for users of the
nkeysto be able to implement this functionality for themselves, all that was needed is the change introduced in #42This PR removes the
jwkfeature to better align this with the upstreamnkeysmodule.Related Issues
Release Information
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification