fix: Catch invalid signature length when verifying signature #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joonas
requested review from
autodidaddict,
brooksmtownsend and
thomastaylor312
as code owners
joonas
force-pushed
the
fix/check-signature-length
branch
from
1c6445b to
eb35335
Compare
joonas
force-pushed
the
fix/check-signature-length
branch
from
eb35335 to
2c69430
Compare
Signed-off-by: Joonas Bergius <joonas@cosmonic.com>
joonas
force-pushed
the
fix/check-signature-length
branch
from
2c69430 to
f7e719d
Compare
|
would love to get this in as part of #45 🙂 |
brooksmtownsend
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
Addresses the example described in #13 where wrong length would cause the
verifymethod to panic.Related Issues
Closes #13
Release Information
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification