-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release via Burrito+Nix #616
Conversation
dd02db6
to
6cb3d92
Compare
The x86 darwin error is interesting. Failed to load workspace members |
Yes, but it actually does not seem to influence the build, just a yet another preview2-prototyping oddity |
e1cee60
to
c9554b2
Compare
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
252eca7
to
e1abd58
Compare
See also #608 (comment) |
82dc903
to
4c6ba3b
Compare
@rvolosatovs is this required? I believe this will break the raspberry pi's running on debian:bullseye, which is the latest raspbian Great callout for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is all fantastic work 🎉 As mentioned in the other comment I verified this works for mac/linux aarch64, will test x86 windows again after leaving this review.
I left a few nit comments, the one that we should probably address is using the -latest
runners or pinned versions, I've opted for the pinned versions just to avoid our pipelines breaking out from under us when runners update, but it's not a hard-held stance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is all fantastic work 🎉 As mentioned in the other comment I verified this works for mac/linux aarch64, will test x86 windows again after leaving this review.
I left a few nit comments, the one that we should probably address is using the -latest
runners or pinned versions, I've opted for the pinned versions just to avoid our pipelines breaking out from under us when runners update, but it's not a hard-held stance.
Edit: Windows works 🎉
683b7aa
to
7f0b742
Compare
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
We should be testing this always, not only on tag pushes Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
Should be done now, please test both GNU builds once CI finishes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once tests pass, works for me on aarch64 linux, mac, and x86 windows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once tests pass, works for me on aarch64 linux, mac, and x86 windows
Could you try to restart them? (Potentially a few times) Since I have not changed the implementation, it appears as a flake to me. Otherwise, could you tell me what is there to be fixed? There are way too many logs and it's impossible to figure out what's wrong for someone unfamiliar with the project (like myself) |
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
Feature or Problem
Closes #589 (no cross, no problem)
Closes #572
Closes #570
Dependencies:
ca-certificates
- self-explanatorylibgcc
- that's actually a NIF dependency, which is added by the Rust compiler -crt-static on musl links with libgcc_s rust-lang/rust#82521After setting the required env variables the release can be reproduced via
release
within a nix shell (nix develop
from anywhere within the repo ornix develop github:wasmcloud/wasmcloud-otp
once the PR is merged)There's also a
make release
target added in the root, which initializes a Nix shell and callsrelease
Note, that you have to first:
SECRET_KEY_BASE
in your environmentNote, that NIFs can also be just fetched from one of CI runs
e.g. I have this in my
.envrc
(you may want to look into https://direnv.net/)(you have to first fetch and unzip the libraries just like CI does, see workflow and error messages, if any)
Related Issues
Release Information
Consumer Impact
Testing
Built on platform(s)
Tested on platform(s)
Unit Test(s)
Acceptance or Integration
Manual Verification