Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wasi) Implement WASI #178

Merged
merged 17 commits into from
Feb 5, 2021
Merged

feat(wasi) Implement WASI #178

merged 17 commits into from
Feb 5, 2021

Conversation

Hywan
Copy link
Contributor

@Hywan Hywan commented Jan 25, 2021

Close #171
Close #72
Close #128
Depend on wasmerio/wasmer#2053 (merged)
Depend on wasmerio/wasmer#2058 (merged)
Depend on wasmerio/wasmer#2059 (merged)
Depend on wasmerio/wasmer#2070 (merged)

Work in Progress. It includes the darwin/aarch64 branch. Will be rebased on master without that before merging of course.

@Hywan Hywan added 🎉 enhancement New feature or request 🧪 tests I love tests labels Jan 25, 2021
@Hywan Hywan requested a review from jubianchi January 25, 2021 15:51
@Hywan Hywan self-assigned this Jan 25, 2021
@Hywan Hywan changed the title feat(wasi) Implement WASI feat(wasi) Implement WASI (TASK-4) Jan 25, 2021
@Hywan Hywan changed the title feat(wasi) Implement WASI (TASK-4) feat(wasi) Implement WASI Jan 28, 2021
Copy link
Contributor

@jubianchi jubianchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good, only one minor suggestion.

wasmer/exports.go Outdated Show resolved Hide resolved
@jubianchi
Copy link
Contributor

bors try

bors bot added a commit that referenced this pull request Feb 2, 2021
@bors
Copy link
Contributor

bors bot commented Feb 2, 2021

try

Build failed:

@Hywan
Copy link
Contributor Author

Hywan commented Feb 5, 2021

bors try

bors bot added a commit that referenced this pull request Feb 5, 2021
Co-authored-by: Julien BIANCHI <contact@jubianchi.Fr>
@bors
Copy link
Contributor

bors bot commented Feb 5, 2021

@Hywan
Copy link
Contributor Author

Hywan commented Feb 5, 2021

bors try

bors bot added a commit that referenced this pull request Feb 5, 2021
@bors
Copy link
Contributor

bors bot commented Feb 5, 2021

try

Build succeeded:

@Hywan Hywan merged commit 9f9f1fb into wasmerio:master Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 enhancement New feature or request 🧪 tests I love tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WASI in v1.0.0
2 participants