fix(import) Fix the &'static hack for imported functions
#186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Pyo3 0.10, it is now possible to get a proper `'py` lifetime for the imported functions dict.
Hywan
added
🐞 bug
|
bors r+ |
|
Nice! FWIW there's a deadlock in pyO3 Also if I can comment on your solution implemented here, |
|
Timed out. |
|
Lol I guess that might have been the deadlock xD |
As suggested by @davidhewitt, `Python` is a zero sized type, which can be copied. So let's copy it. Also, the lifetime `'py` can now be properly inferred by the borrow checker. Let's enjoy.
|
I don't think it is related to the deadlock, but only Bors being Bors sometimes ;-) (kidding, this tool is awesome). You're right, the lifetime can now be inferred properly by the borrow checker! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #185.
Follow up of #140.
Good job @kngwyu and @davidhewitt!