Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Test the JIT engine being dropped twice through the Store #1580

Closed
wants to merge 4 commits into from
Closed

test: Test the JIT engine being dropped twice through the Store #1580

wants to merge 4 commits into from

Conversation

Hywan
Copy link
Contributor

@Hywan Hywan commented Aug 31, 2020

I think we have a bug in the engine-jit where the UnwindRegistry on Linux (Ubuntu) fails when dropped twice.

This PR adds a test to check that.

@Hywan Hywan added the 🧪 tests I love tests label Aug 31, 2020
@Hywan
Copy link
Contributor Author

Hywan commented Aug 31, 2020

bors try

bors bot added a commit that referenced this pull request Aug 31, 2020
@bors
Try #1580:
40cc043
@Hywan
Copy link
Contributor Author

Hywan commented Aug 31, 2020

bors try

@bors
Copy link
Contributor

bors bot commented Aug 31, 2020

try

Already running a review

@Hywan
Copy link
Contributor Author

Hywan commented Aug 31, 2020

bors cancel

@Hywan
Copy link
Contributor Author

Hywan commented Aug 31, 2020

bors try

@bors
Copy link
Contributor

bors bot commented Aug 31, 2020

try

Already running a review

@Hywan
Copy link
Contributor Author

Hywan commented Aug 31, 2020

bors try

@bors
Copy link
Contributor

bors bot commented Aug 31, 2020

try

Already running a review

@Hywan
Copy link
Contributor Author

Hywan commented Aug 31, 2020

bors try

@bors
Copy link
Contributor

bors bot commented Aug 31, 2020

try

Already running a review

@syrusakbary
Copy link
Member

bors try

@bors
Copy link
Contributor

bors bot commented Aug 31, 2020

try

Already running a review

@sebpuetz
Copy link

Just wondering if you saw #1568: The UnwindRegistry is not dropped twice. A Vec<u8> owned by CodeMemory inside the Store containing the empty frame gets dropped before deregistering the frames. This Vec's buffer then gets overwritten and the orginally 0-length entry gets changed to some nonsense which causes the abort.

@Hywan
Copy link
Contributor Author

Hywan commented Aug 31, 2020

Yup, this PR was just a test!

@Hywan Hywan closed this Aug 31, 2020
@bors
Copy link
Contributor

bors bot commented Aug 31, 2020

try

Timed out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkMcCaskey MarkMcCaskey Awaiting requested review from MarkMcCaskey

@syrusakbary syrusakbary Awaiting requested review from syrusakbary

Assignees
No one assigned
Labels
🧪 tests I love tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hywan @syrusakbary @sebpuetz