Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CHANGELOG generation to list by PR merged date, not created date #3419

Merged
merged 3 commits into from
Dec 12, 2022
Merged

Fix CHANGELOG generation to list by PR merged date, not created date #3419

merged 3 commits into from
Dec 12, 2022

Conversation

fschutt
Copy link
Contributor

@fschutt fschutt commented Dec 12, 2022 •
edited
Loading

No description provided.

@fschutt fschutt requested a review from syrusakbary as a code owner December 12, 2022 16:41
@fschutt fschutt marked this pull request as draft December 12, 2022 16:42
@fschutt fschutt marked this pull request as ready for review December 12, 2022 18:16
theduke
theduke approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@theduke theduke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess our changelogs were always wrong until now, so the updating of the history is fine, as are the code changes.

But we really need to change our changelog workflow in the future.

@fschutt
Copy link
Contributor Author

fschutt commented Dec 12, 2022

bors r+

@fschutt
Copy link
Contributor Author

fschutt commented Dec 12, 2022 •
edited
Loading

@theduke the order of items changed making the diff a lot bigger than it should have been, but yeah at least it's complete now

@bors
Copy link
Contributor

bors bot commented Dec 12, 2022

Build succeeded:

@bors bors bot merged commit 87bc54c into master Dec 12, 2022
@bors bors bot deleted the fix-changelog-generation branch December 12, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theduke theduke theduke approved these changes

@syrusakbary syrusakbary Awaiting requested review from syrusakbary

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fschutt @theduke