forked from bytecodealliance/wasm-tools
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge up to release v1.216.0 #128
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tecodealliance#1711) * implement architecture adaptible data layout * make add_assign and align_to_arch available * conversion function from alignment * new method to quickly add some bytes to it * implementing Display takes care of many errors in wit-bindgen * more compatibility tweaks * simplify code generation * more nice formatting, minor rename * shorten code by new() * fix logic error * document and introduce compatibility to previous versions * remove merge artifact * make code compatible with 1.76.0 * fix the fuzzer (resource returned different MAX value) * correct addition, simplify align, new test * add documentation * remove compatibility type alias * Add SizeAlign comparison fuzzer * run rustfmt, use old wit-smith version * use pointers and bytes as separate entities * add new testcase (found in fuzzing) and correct ptr to 8 byte alignment logic * correct empty logic after pointer separation
* threads: add tests for `ref.i31_shared` This change brings in Binaryen's existing [`shared-i31.wast`] test, with the commented-out parts that Binaryen does not yet support enabled here. To get this to pass in `wasm-tools`, we add the ability to parse `ref.i31_shared` as a constant expression in WAST. [`shared-i31.wast`]: https://github.com/WebAssembly/binaryen/blob/main/test/spec/shared-i31.wast * review: validate constant expressions for shared-everything-threads
* Update Wasmtime to 24.0.0 in testing * Update test expectations * Skip some crate tests on msrv * Bump before verify in CI Try to ensure that the versions being pseudo-packaged are guaranteed to not exist in crates.io to not conflict with the crates.io-based versions.
* threads: check mutability for `struct.atomic.rmw.*` instructions Previously this was not being checked; this adds tests which force new validation logic. * threads: check mutability for `array.atomic.rmw.*` instructions * review: add `mutable_struct_field_at` * review: add `mutable_array_field_at` * fix: formatting
…liance#1732) This commit enables three new proposals by default in `WasmFeatures` to reflect the stage 4+ status of the proposals.
* Add a feature for disabling GC types This commit adds support for a new wasm feature named `WasmFeatures::GC_TYPES`. This does not correspond to any upstream proposal and is intended for use in Wasmtime for disabling the runtime garbage collector at compile time. This serves as a finer-grained switch to disable the runtime dependency at validation time on a garbage collector without disabling all the features that were added in other proposals. For example the `reference-types` proposal also added support for multi-table which disabling a runtime garbage collector doesn't need to disable. * Fix wasm-smith tests * Fix test expectation
This commit refactors users of `pop_ref` during validation to be able to pass in an expected type. This removes the need for a few manual `is_subtype` checks and helps centralize type-checking in one location.
…1734) * Update handling of unreachable code and heap types This commit updates validation of wasm modules with unreachable code using gc/heap types. It notably fixes cases with the shared-everything-threads proposal where existing instructions are polymorphic over `shared` and not and wasn't supported before. Specifically code was refactored to use `MaybeType` a bit more to propagate the bottom-ness and the `MaybeType::HeapBot` variant has grown a new `AbstractHeapType` payload for various instructions to use such as `any.convert_extern`. * Fix dead code warning
[automatically-tag-and-release-this-commit] Co-authored-by: Auto Release Process <auto-release-process@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.