Merge with upstream #134
Merged
Merge with upstream #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allow parsing `rectypes` in components This change supports [bytecodealliance#392], which adds a way to use GC's `rectypes` as type definitions in components. Previously, only function types were supported and there was no way express array and struct types. This keeps the previous function decoding support based on peeking the function type `0x60` prefix but adds support for encoding `rectypes` with a new `0x00` prefix. [bytecodealliance#392]: WebAssembly/component-model#392 Co-authored-by: Alex Crichton <alex@alexcrichton.com> * Apply `0x00` prefix to non-final `sub`; add tests This follows along with the most recent discussion in the component model PR ([bytecodealliance#392]). [bytecodealliance#392]: WebAssembly/component-model#392 Co-authored-by: Alex Crichton <alex@alexcrichton.com> * review: keep variant as `ComponentCoreTypeId::Sub` * review: remove leftover comment * review: remove resolved TODOs * review: move `From` implementations to `core/binary.rs` * review: remove `parse_component_sub_type` --------- Co-authored-by: Alex Crichton <alex@alexcrichton.com>
…1776) The very large diffs from errors in development bytecodealliance#1775 caused OOMs so I figured now's as good a time as any to switch over to using `pretty_assertions` which other crates in the workspace are already using.
…e#1778) This'll in theory get updated occasionally but should protect us from breakage in the meantime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.