add extension trait for BoundedRegSpan::from_providers

wasmi-labs · Sep 17, 2024 · 0af1152 · 0af1152
1 parent 1c80fcb
commit 0af1152
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/crates/wasmi/src/engine/translator/instr_encoder.rs b/crates/wasmi/src/engine/translator/instr_encoder.rs
@@ -1,5 +1,6 @@
 use super::{
     relink_result::RelinkResult as _,
+    utils::FromProviders as _,
     visit_register::VisitInputRegisters as _,
     FuelInfo,
     LabelRef,

diff --git a/crates/wasmi/src/engine/translator/mod.rs b/crates/wasmi/src/engine/translator/mod.rs
@@ -28,7 +28,7 @@ use self::{
     labels::{LabelRef, LabelRegistry},
     provider::{Provider, ProviderSliceStack, UntypedProvider},
     stack::ValueStack,
-    utils::{WasmFloat, WasmInteger},
+    utils::{FromProviders as _, WasmFloat, WasmInteger},
 };
 pub use self::{
     control_frame::{ControlFrame, ControlFrameKind},

diff --git a/crates/wasmi/src/engine/translator/utils.rs b/crates/wasmi/src/engine/translator/utils.rs
@@ -147,14 +147,19 @@ impl TypedProvider {
     }
 }
 
-impl BoundedRegSpan {
+/// Extension trait to create a [`BoundedRegSpan`] from a slice of [`TypedProvider`]s.
+pub trait FromProviders: Sized {
     /// Creates a [`BoundedRegSpan`] from the given slice of [`TypedProvider`] if possible.
     ///
     /// All [`TypedProvider`] must be [`Reg`] and have
     /// contiguous indices for the conversion to succeed.
     ///
     /// Returns `None` if the `providers` slice is empty.
-    pub fn from_providers(providers: &[TypedProvider]) -> Option<Self> {
+    fn from_providers(providers: &[TypedProvider]) -> Option<Self>;
+}
+
+impl FromProviders for BoundedRegSpan {
+    fn from_providers(providers: &[TypedProvider]) -> Option<Self> {
         let (first, rest) = providers.split_first()?;
         let first_index = first.register_index()?;
         let mut prev_index = first_index;