Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local preservation when chaining local.set #1057

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented Jun 4, 2024

Fixes the test case reported in #1051 (comment).

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.73%. Comparing base (a817996) to head (cd88aa8).

Files Patch % Lines
...asmi/src/engine/translator/stack/register_alloc.rs 88.88% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1057   +/-   ##
=======================================
  Coverage   80.72%   80.73%           
=======================================
  Files         268      268           
  Lines       25006    25028   +22     
=======================================
+ Hits        20186    20206   +20     
- Misses       4820     4822    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robbepop Robbepop merged commit 2e9d32b into master Jun 4, 2024
18 checks passed
@Robbepop Robbepop deleted the rf-fix-local.set-v3 branch June 4, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant